Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10497: Fix Windows 8 and Windows Phone 8 behavior and apply to docs #10584

Merged
merged 3 commits into from
Sep 11, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 11, 2013

Per #10497, some things for Windows 8, Windows Phone 8, and Internet Explorer 10 are not what they seem. This pull request fixes a few things up around that:

  • Drops the global @ms-viewport usage that was causing Windows Phone 8 devices to display scaled down versions of a "desktop site"
  • Clarifies the docs in the Browser Support section on the Getting Started page to provide additional context
  • Applies the fix to the docs so folks have an example to pull from if need be.

/cc @cvrebert @laurentperez

<h3>Windows Phone 8 and Internet Explorer 10</h3>
<p>Internet Explorer 10 doesn't differentiate device width from viewport width, and thus doesn't properly apply the media queries in Bootstrap's CSS. To address this, you can optionally include the following CSS and JavaScript to work around this problem until Microsoft issues a fix.</p>
<h3>Internet Explorer 10 in Windows 8 and Windows Phone 8</h3>
<p>Internet Explorer 10 doesn't differentiate <strong>device width</strong> from <storng>viewport width</storng>, and thus doesn't properly apply the media queries in Bootstrap's CSS. Normally you'd just add a quick snippet of CSS to fix this:</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"storng" typo in the one tag pair

@cvrebert
Copy link
Collaborator

Perhaps give the actual URL for the Getting Started page instead or in addition to referencing it by name?

@cvrebert
Copy link
Collaborator

I took the liberty of rebasing in some trivial copyedits.

…ports

Conflicts:
	getting-started.html
	less/responsive-utilities.less
@mdo
Copy link
Member Author

mdo commented Sep 11, 2013

I fetched your changes but it conflicted for some reason—and I'm too out of it so my low git-fu escapes me. Tried to resolve them with your changes intact while adding a few new changes, including a docs link.

mdo added a commit that referenced this pull request Sep 11, 2013
Fixes #10497: Fix Windows 8 and Windows Phone 8 behavior and apply to docs
@mdo mdo merged commit cd7cf40 into master Sep 11, 2013
@mdo mdo deleted the ie_viewports branch September 11, 2013 23:19
@mdo mdo mentioned this pull request Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants